• op-bindings/bindings/disputegamefactory.go is excluded by !op-bindings/bindings/**
• op-bindings/bindings/disputegamefactory_more.go is excluded by !op-bindings/bindings/**
• op-bindings/bindings/faultdisputegame.go is excluded by !op-bindings/bindings/**
• op-bindings/bindings/faultdisputegame_more.go is excluded by !op-bindings/bindings/**
• packages/contracts-bedrock/semver-lock.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/abi/FaultDisputeGame.json is excluded by !**/*.json
• packages/contracts-bedrock/snapshots/abi/PermissionedDisputeGame.json is excluded by !**/*.json

• packages/contracts-bedrock/src/dispute/DisputeGameFactory.sol (2 hunks)
• packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol (5 hunks)
• packages/contracts-bedrock/src/dispute/interfaces/IDisputeGame.sol (1 hunks)
• packages/contracts-bedrock/src/dispute/interfaces/IFaultDisputeGame.sol (1 hunks)
• packages/contracts-bedrock/src/libraries/DisputeErrors.sol (1 hunks)
• packages/contracts-bedrock/test/dispute/FaultDisputeGame.t.sol (4 hunks)

packages/contracts-bedrock/src/dispute/interfaces/IDisputeGame.sol (4)

33-37: Renaming gameType to gameCreator and its updated functionality align well with the PR's objectives.

---

38-39: Addition of rootClaim function enhances data handling capabilities in dispute games.

---

43-46: Introduction of l1Head function supports better traceability of the dispute game's creation context.

---

49-49: Addition of extraData function enhances the flexibility of dispute games by allowing additional data association.

packages/contracts-bedrock/src/libraries/DisputeErrors.sol (1)

39-40: Renaming ExtraDataTooLong to BadExtraData improves clarity and specificity in error reporting.

packages/contracts-bedrock/src/dispute/DisputeGameFactory.sol (2)

26-27: Update of semantic version to "0.5.0" is appropriate given the significant changes in contract functionalities.

---

106-116: Inclusion of msg.sender in the clone function enhances traceability and aligns with the PR's objectives to treat smart wallets as first-class entities.

Verification successful

---

The changes to the clone function in DisputeGameFactory.sol have been correctly implemented, and there are no outdated references in other Solidity files. The inclusion of msg.sender in the clone function is verified as per the PR's objectives.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Search for any remaining references to the old `clone` function signature in the codebase.
rg --type sol 'clone\(.*\)'

Length of output: 57

---

---

Script:

#!/bin/bash
# Search for any remaining references to the old `clone` function signature in the codebase without specifying file type.
rg 'clone\(.*\)'

Length of output: 804

packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol (6)

91-92: Updated version constant to "0.12.0" aligns with the PR's objective to enhance the dispute game mechanism.

---

449-452: The gameCreator function has been added to retrieve the address of the game creator from calldata. This is a new feature that supports the PR's goal of treating smart wallets as first-class entities.

---

456-457: The rootClaim function has been added to retrieve the root claim from calldata. This function supports the enhanced data handling capabilities mentioned in the PR summary.

---

460-461: The l1Head function has been added to retrieve the L1 head hash from calldata. This addition is part of the adjustments to improve data management in the dispute game mechanism.

---

468-468: The extraData function has been adjusted to retrieve 32 bytes of extra data starting from the second word within the calldata. Verify that the offset 0x54 and length 0x20 are correctly used to fetch the intended extra data.

Verification successful

---

The search results confirm that the offset 0x54 and length 0x20 are used in the FaultDisputeGame.sol file to fetch extra data, as specified in the review comment. This is the only occurrence found in the codebase, which aligns with the intended usage described in the review comment. Therefore, the implementation of the extraData_ fetching mechanism using these parameters is verified to be correct.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Verify that the offset 0x54 and length 0x20 are correctly used to fetch extra data across the codebase.
rg --type solidity $'0x54, 0x20'

Length of output: 66

---

---

Script:

#!/bin/bash
# Verify that the offset 0x54 and length 0x20 are correctly used to fetch extra data across the codebase.
rg '0x54, 0x20' *.sol

Length of output: 71

---

---

Script:

#!/bin/bash
# Verify that the offset 0x54 and length 0x20 are correctly used to fetch extra data across the codebase.
rg '0x54, 0x20' --glob '*.sol' -uu

Length of output: 143

---

521-537: Modified calldata size check to prevent incorrect game UUID creation. This change is crucial for ensuring the integrity of game instance creation. Verify that the expected calldata size 0x7A is consistent with the structure of the calldata used across related contracts.

packages/contracts-bedrock/test/dispute/FaultDisputeGame.t.sol (1)

178-194: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [182-201]

Renamed test function and adjusted logic for _extraDataLen handling.

The renaming of the test function from testFuzz_initialize_extraDataTooLong_reverts to testFuzz_initialize_badExtraData_reverts aligns with the error name change in the contract. The logic adjustment in setting _extraDataLen to skip the exact 32 bytes length by incrementing it ensures that the test covers the scenario where the extra data is just above the valid threshold, which is a good edge case to test.